Hopefully this PR could help close

#119

#120

Hi @jtpio @jasongrout @hbcarlos

I have make it consistent in JupyterLab 4, could you help check the CI/CD part and have a further look? I don't have permission to build wheel package.

It is common branching rule for now, how shall we bump version then?

Hi @jtpio @jasongrout @hbcarlos

I have make it consistent in JupyterLab 4, could you help check the CI/CD part and have a further look? I don't have permission to build wheel package.

@krassowski, could you help update the Jlab 4 extension issue?

thanks @jtpio for triggering this, let me fix it

Hi @jtpio

There was 3 error during build.

For build https://github.com/QuantStack/jupyterlab-drawio/actions/runs/9469049944/job/26324630827?pr=121, looks like I need to format style/base.css

For check release https://github.com/QuantStack/jupyterlab-drawio/actions/runs/9469049949/job/26324630065?pr=121, looks like somehow incorrect repository url generaetd

I have fixed the above 2, please help re-trigger

for "force label" could you add a label to this PR?

Makes a few renaming change (basically jupyterlab_drawio to jupyterlab-drawio)

BTW, is it correct that we shall remove juptyerlab-drawio/_version.py file, to let hatch version command to bump it automatically?

thanks for triggering this, looks better.

For build issue, looks like there is a markdown file suffixed as js, it behaves similarly on my local... Let me ignore it.

For the force label error, @jtpio can you help add a label on this pr?

thanks, I would try to fix build failure later today

hi @jtpio , I have the whole folder src/drawio/resources ignored since no JS/TS/CSS code here at all, please help re-trigger workflow

quick edit here, the whole src/drawio would be ignored for prettier, since there are lots of JS looks like static asset. The previous prettier would make more than 400k lines of change, which is kind of overkill

Hi @jtpio, looks like somehow enforce label check still failed.

looks like it checks issue's label, rather than PR.

Please advise that what shall we do...

1. mark this PR as closes JupyterLab 4 support tracking issue #120 and add triage label there?
2. totally remove this check? after all, it is not JupyterLab and looks like only BAU change...

For build issue, I only formatted the ts code I made change, while it exits 1 if not everything well-formatted

it works locally, sorry that I use @ts-ignore since we shall leave legacy code and minimise the real code-level change

@jtpio , sorry for a reset commit.

The reason is that I try to format code to pass link, while in src/drawio, some JS code are real code but some other code file looks like static assert. Hence, prettier brings lot of irrelevant change then.

The current change pass lint and wheel-build workflow on my local, please help trigger workflow again

hmmmm sry that I am not familiar with Jupyter workflow may I know what does below means... after change the check does not run?

Hello @jtpio , @bollwyvl , can you help advise on the version bump, and help kick-off a latest check?